Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Plugin Handling in Gateway #549

Merged
merged 15 commits into from
Jul 15, 2024
Merged

feat: Plugin Handling in Gateway #549

merged 15 commits into from
Jul 15, 2024

Conversation

Vinodsathyaseelan
Copy link
Contributor

@Vinodsathyaseelan Vinodsathyaseelan commented Jun 27, 2024 •
edited
Loading

What

Add better Thunder plugin status handling in Gateway

Why

As a Ripple API Gateway component, Thunder Plugin activation and status needs to be managed by the Thunder broker.

How

Added a new component name ThunderStateManager. This will be used by Thunder Broker to check thunder plugin status.

Test

I have tested the features by running unit test cases

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@Vinodsathyaseelan Vinodsathyaseelan marked this pull request as draft June 27, 2024 03:19
@Vinodsathyaseelan Vinodsathyaseelan marked this pull request as ready for review June 27, 2024 08:53
@Vinodsathyaseelan Vinodsathyaseelan requested review from satlead and a team June 27, 2024 21:34
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Health
device.thunder_ripple_sdk.src.processors.events 0% ❌
device.thunder_ripple_sdk.src.processors 10% ❌
device.thunder_ripple_sdk.src.events 4% ❌
core.sdk.src.api.gateway 85% ✔
device.mock_device.src 52% ➖
core.main.src.bootstrap.manifest 0% ❌
core.main.src.state.cap 44% ➖
device.thunder_ripple_sdk.src.client 74% ➖
core.tdk.src.utils 0% ❌
device.thunder_ripple_sdk.src.bootstrap 0% ❌
distributor.general.src 2% ❌
core.sdk.src.extn 83% ✔
device.thunder_ripple_sdk.src 15% ❌
core.sdk.src.api.manifest 91% ✔
core.main.src 0% ❌
core.sdk.src.framework 75% ➖
core.main.src.broker 21% ❌
core.main.src.utils 10% ❌
core.main.src.broker.thunder 55% ➖
core.tdk.src.gateway 100% ✔
core.main.src.service.apps 47% ➖
device.thunder.src.bootstrap 0% ❌
core.launcher.src 0% ❌
openrpc_validator.src 90% ✔
core.sdk.src.api.device 77% ✔
core.main.src.bootstrap.extn 0% ❌
core.main.src.bootstrap 0% ❌
core.launcher.src.manager 7% ❌
core.sdk.src.extn.ffi 80% ✔
core.main.src.service 31% ❌
core.main.src.processor 0% ❌
core.sdk.src.utils 53% ➖
core.sdk.src.extn.client 91% ✔
core.main.src.firebolt.handlers 1% ❌
core.main.src.processor.storage 0% ❌
core.sdk.src.api.firebolt 78% ✔
core.main.src.firebolt 1% ❌
core.main.src.service.extn 41% ❌
core.sdk.src.api.distributor 84% ✔
device.thunder.src 0% ❌
core.sdk.src.api 78% ✔
core.sdk.src.api.observability 68% ➖
core.main.src.state 22% ❌
Summary 42% (16763 / 39476) ➖

Minimum allowed line rate is 41%

@Vinodsathyaseelan Vinodsathyaseelan merged commit b9600e6 into main Jul 15, 2024
8 checks passed
@Vinodsathyaseelan Vinodsathyaseelan deleted the RPPL-2132 branch July 15, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nv-Delle1416 Nv-Delle1416 Nv-Delle1416 approved these changes

@satlead satlead satlead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vinodsathyaseelan @satlead @Nv-Delle1416